fix: CN-482 use correct falsy checks #726
Open
+220
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-catlin
changed the title
PR Reviewer Guide 🔍
|
parker-snyk
approved these changes
Nov 13, 2025
| } | ||
|
|
||
| if (pkg.epoch) { | ||
| if (pkg.epoch !== undefined && pkg.epoch !== null) { |
Contributor
There was a problem hiding this comment.
Does this handle pkg.epoch = 0 correctly? I'm not too familiar with the dumpster fire wonderful joy that is true/false checks in JS, and I'm also not familiar with the pkg.epoch
Contributor
There was a problem hiding this comment.
Disregard this, I need to learn to read the full PR message before looking at the code
adrobuta
reviewed
Nov 14, 2025
| } | ||
|
|
||
| if (pkg.epoch) { | ||
| if (pkg.epoch !== undefined && pkg.epoch !== null) { |
Contributor
There was a problem hiding this comment.
https://github.com/snyk/rpm-parser/blob/39c308effb038b5be0f2de4c4e2c9c8dd18b9dcb/lib/index.ts#L56 formatRpmVersion omits the epoch if it's 0, do you think it would need any update to match the purl?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
javascript interprets the number 0 as falsy, but 0 is the default epoch for rpm packages; this means that any time we have an rpm package with epoch 0, we just throw it straight in the garbage.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/CN-482